Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix goroutine leak when reconciling" #614

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Sep 9, 2024

Description of your changes

This reverts commit 0927b1f.

With the above-reverted change, we encountered issues creating and deleting some resources.

  • examples/cloudplatform/v1beta1/projectservice.yaml
    message: 'async create failed: failed to create the resource: [{0 Error when reading
      or editing Project Service : Parent context of request project/official-provider-testing/services
      canceled  []}]'
  • examples/cloudplatform/v1beta1/projectiammember.yaml
    message: 'create failed: async create failed: failed to create the resource: [{0
      Parent context of request iam-project-official-provider-testing modifyIamPolicy
      canceled  []}]'
  • examples/container/v1beta1/cluster.yaml
    message: 'create failed: async create failed: cannot get connection details: cannot
      get additional connection details: endpoint: not a string'
    message: 'async delete failed: failed to delete the resource: [{0 Error waiting
      for deleting GKE cluster: error while retrieving operation: unable to finish
      polling, context has been cancelled  []}]'

Fixes #611

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

The above failed tests have been tested manually and with uptest:

NAME                                                          SYNCED   READY   EXTERNAL-NAME                                          AGE
projectservice.cloudplatform.gcp.upbound.io/project-service   True     True    official-provider-testing/clouddeploy.googleapis.com   2m8s
NAME                                                                SYNCED   READY   EXTERNAL-NAME
                                                    AGE
projectiammember.cloudplatform.gcp.upbound.io/project-iam-member2   True     True    official-provider-testing/roles/viewer/serviceAccount:official-provider-testing-noop@
official-provider-testing.iam.gserviceaccount.com   2m25s
NAME                                       SYNCED   READY   EXTERNAL-NAME   AGE
cluster.container.gcp.upbound.io/primary   True     True    primary         8m30s

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 9, 2024

/test-examples="examples/container/v1beta1/cluster.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 9, 2024

/test-examples="examples/cloudplatform/v1beta1/projectiammember.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 9, 2024

/test-examples="examples/cloudplatform/v1beta1/projectservice.yaml"

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf. LGTM.

@turkenf turkenf merged commit f528eed into crossplane-contrib:main Sep 9, 2024
12 checks passed
@turkenf turkenf deleted the revert-PR539 branch September 9, 2024 12:33
Copy link

github-actions bot commented Sep 9, 2024

Successfully created backport PR #615 for release-1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Resources gets stuck creating forever with 1.8.0
2 participants