Revert "Fix goroutine leak when reconciling" #614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This reverts commit 0927b1f.
With the above-reverted change, we encountered issues creating and deleting some resources.
examples/cloudplatform/v1beta1/projectservice.yaml
examples/cloudplatform/v1beta1/projectiammember.yaml
examples/container/v1beta1/cluster.yaml
Fixes #611
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
The above failed tests have been tested manually and with uptest:
examples/cloudplatform/v1beta1/projectservice.yaml
: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10771811848examples/cloudplatform/v1beta1/projectiammember.yaml
: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10771726984examples/container/v1beta1/cluster.yaml
: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/10771724541