Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trivy scan workflow and scan config packages #569

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Jul 12, 2024

Description of your changes

After stopping the support to the monolithic packages, our scan workflows fails.
In this PR, the monolithic package in the workflow has been replaced with the config package.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/9909582882

@turkenf turkenf requested a review from phisco July 12, 2024 13:50
Copy link
Contributor

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, I checked and it also contains the binary, so it should be fine

@turkenf turkenf marked this pull request as ready for review July 12, 2024 14:00
Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf and @phisco.

@turkenf turkenf merged commit e4edfbc into crossplane-contrib:main Jul 12, 2024
9 checks passed
@turkenf turkenf deleted the update-trivy-scan branch July 12, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants