Add google_storage_hmac_key #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow creating HMAC keys for Cloud Storage. This has been tested and applying the following results in a successful creation of a HMAC key. Its private key is written to the target namespace: examples/storage/v1beta1/hmackey.yaml Signed-off-by: Jakub Ciolek <[email protected]>
jake-ciolek
requested review from
ulucinar,
sergenyalcin and
turkenf
as code owners
This was referenced Jun 18, 2024
|
/test-examples="examples/storage/v1beta1/hmackey.yaml" |
|
#@jake-ciolek thank you for this contribution. The maintainers are on PTO this week, but we'll look at it when they are back and aim to release a new version of the provider before month end. |
turkenf
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creating HMAC keys for GCP Cloud Storage.
This has been tested and applying the following results in a successful creation of a HMAC key. Its private key is written to the target namespace. To check on your machine, try out the example in:
We at AlphaSense would appreciate if you could review this one as we rely on it for one of our internal initiatives.
Description of your changes
This adds the ability to manage GCP Cloud Storage HMAC keys through Crossplane.
There was an earlier pull request by someone else, see #261 which unfortunately got closed due to issues with Upjet and import cycles. Those issues were resolved since then.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Ran make reviewable and also tried out the resource in my GCP project (creation, deletion and secret creation).
A successful uptest run: https://github.com/crossplane-contrib/provider-upjet-gcp/actions/runs/9565894913