Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP address(host) to secret for Instance.redis #405

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Oct 5, 2023

Description of your changes

This PR adds IP address to secret for Instance.redis resource.

Fixes: #387

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Tested manually:

> k describe secret example-redis-instance-secret -n upbound-system
Name:         example-redis-instance-secret
Namespace:    upbound-system
Labels:       <none>
Annotations:  <none>

Type:  connection.crossplane.io/v1alpha1

Data
====
host:                   13 bytes
attribute.auth_string:  36 bytes

@turkenf
Copy link
Collaborator Author

turkenf commented Oct 5, 2023

/test-examples="examples/redis/instance.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.

@turkenf turkenf merged commit ab0d768 into crossplane-contrib:main Oct 23, 2023
8 checks passed
@turkenf turkenf deleted the issue-387 branch October 23, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[provider-Redis] writeConnectionSecretToRef doesn't publish ip address
2 participants