Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add iam bindings #342

Conversation

bradkwadsworth-mw
Copy link
Contributor

Description of your changes

Added IAM binding resources for folders, projects, and service accounts.
Fixes #13

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Created resources in existing GCP org. Also ran make local-deploy.

@turkenf
Copy link
Collaborator

turkenf commented Jul 26, 2023

/test-examples="examples/cloudplatform/serviceaccountiambinding.yaml"

@turkenf
Copy link
Collaborator

turkenf commented Jul 26, 2023

Could you please add the screenshots under the How has this code been tested title? Please see: #198

@turkenf
Copy link
Collaborator

turkenf commented Jul 27, 2023

/test-examples="examples/cloudplatform/projectiammember.yaml"

metadata:
annotations:
meta.upbound.io/example-id: cloudplatform/v1beta1/projectiambinding
upjet.upbound.io/manual-intervention: "Depends on a valid project & member"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
upjet.upbound.io/manual-intervention: "Depends on a valid project & member"

Could you please remove manual-intervention, these parameters are passed by the uptest?

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bradkwadsworth-mw, I left a comment and could you please note the following in the description of your PRs?

  • The issue you mentioned in the fixes section will be closed with the merge of this PR. I think this PR does not fully cover the issue(Configure remaining GCP resources without testing #13). So can you fix the fixes part? For instance, you can add the list of resources you have configured here, and remove the Fixes section.
  • As I mentioned in the comment, can you be more clear on how it was tested?

And I'm also worried about adding these resources because of this issue. I need to discuss this with the team and we can continue.

@turkenf
Copy link
Collaborator

turkenf commented Jul 28, 2023

Hi @bradkwadsworth-mw,

I discussed this PR with the team and as I mentioned above there is an issue with adding *_iam_binding resources. As mentioned in the issue, there is an incompatibility with using *_iam_member, *_iam_binding, and *_iam_policy resources together. The *_iam_member resources have been tested and added to the v1beta1 version, if you cannot do with *_iam_member what you can do with *_iam_binding, please leave a comment to the issue. That's why I'm closing this PR for now.

Related issue, feel free to comment, thank you!

@turkenf turkenf closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure remaining GCP resources without testing
2 participants