-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add iam bindings #342
Feature/add iam bindings #342
Conversation
Signed-off-by: Brad Wadsworth <[email protected]>
/test-examples="examples/cloudplatform/serviceaccountiambinding.yaml" |
Could you please add the screenshots under the |
/test-examples="examples/cloudplatform/projectiammember.yaml" |
metadata: | ||
annotations: | ||
meta.upbound.io/example-id: cloudplatform/v1beta1/projectiambinding | ||
upjet.upbound.io/manual-intervention: "Depends on a valid project & member" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upjet.upbound.io/manual-intervention: "Depends on a valid project & member" |
Could you please remove manual-intervention, these parameters are passed by the uptest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bradkwadsworth-mw, I left a comment and could you please note the following in the description of your PRs?
- The issue you mentioned in the fixes section will be closed with the merge of this PR. I think this PR does not fully cover the issue(Configure remaining GCP resources without testing #13). So can you fix the fixes part? For instance, you can add the list of resources you have configured here, and remove the
Fixes
section. - As I mentioned in the comment, can you be more clear on how it was tested?
And I'm also worried about adding these resources because of this issue. I need to discuss this with the team and we can continue.
I discussed this PR with the team and as I mentioned above there is an issue with adding Related issue, feel free to comment, thank you! |
Description of your changes
Added IAM binding resources for folders, projects, and service accounts.
Fixes #13
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Created resources in existing GCP org. Also ran
make local-deploy
.