-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support auth annotations for Upbound #295
Support auth annotations for Upbound #295
Conversation
Note -- this is not functioning in its current state. The package-level annotation is being injected, but not the CRD-level annotations on the ProviderConfig (even with a raw |
Hi @jastang, |
Let's wait for #299, which replaces the multiple versions of the package metadata (crossplane-config.yaml, crossplane-monolith.yaml and crossplane.yaml) with a template file. Once that one is merged, I will rebase this onto it and adjust accordingly. |
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
e93739c
to
3ea0996
Compare
Hi @jastang, I've rebased the PR and it's ready for review. |
/test-examples="examples/cloudplatform/serviceaccount.yaml" |
thanks @ulucinar! I don't think that should block this PR, but is there a reason to only support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jastang LGTM!
Description of your changes
Bumps the build submodule to pick up changes that support adding ProviderConfig documentation for Upbound via the auth annotations (
auth.yaml
).Fixes https://github.com/upbound/squad-upbound-cloud/issues/1218
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Built and pushed the config & monolithic packages using this PR. The packages will be shared via a different communication channel.