Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving tpu(1), workflows(1) resources to v1beta1 version #219

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

MyzaTaras
Copy link
Contributor

@MyzaTaras MyzaTaras commented Feb 7, 2023

Description of your changes

Moving 1 resource to v1beta1 version

Moving 1 resource to v1beta1 version

Fixes #214

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual and Uptest:
google_tpu_node - Link

google_workflows_workflow- Link

tpu:
- google_tpu_node

workflows:
- google_workflows_workflow
@MyzaTaras MyzaTaras self-assigned this Feb 7, 2023
@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/tpu/node.yaml"

@MyzaTaras
Copy link
Contributor Author

/test-examples="examples/workflows/workflow.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MyzaTaras LGTM!

@MyzaTaras MyzaTaras merged commit 2337c2f into crossplane-contrib:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving tpu(1), workflows(1) resources to v1beta1 version
2 participants