Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps dependencies used in Github workflows #215

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

ulucinar
Copy link
Collaborator

@ulucinar ulucinar commented Feb 7, 2023

Description of your changes

Bumps fkirc/skip-duplicate-actions Github action to v5.3.0. Also remove usages of the deprecated set-output and save-state Github commands:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

We also bump the actions/cache and the docker/setup-buildx-action actions to v3 and v2, respectively, as the current versions make use of the deprecated save-state command.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

The new dependency's been available in this run:
https://github.com/upbound/provider-aws/actions/runs/4111881233/jobs/7096129032

image

And in the following run with an amended commit, the jobs were successfully skipped:
https://github.com/upbound/provider-aws/actions/runs/4111973225/jobs/7096326530

image

Regarding the actions/cache dependency, Github no longer complains about the deprecated save-state command in the logs of the steps using this action and a cached item was successfully restored as the logs below show:

image

- Bump fkirc/skip-duplicate-actions Github action to v5.3.0
- Remove the deprecated set-output command usage from Github jobs
- Bump actions/cache Github action to v3
- Bump docker/setup-buildx-action Github action to v2

Signed-off-by: Alper Rifat Ulucinar <[email protected]>
Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ulucinar LGTM!

@ulucinar ulucinar merged commit 5e9926d into crossplane-contrib:main Feb 7, 2023
@ulucinar ulucinar deleted the fix-e1 branch February 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants