Feature/add project shared vpc resources selectors #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradkwadsworth-mw
force-pushed
the
feature/add-project-shared-vpc-resources
branch
2 times, most recently
from
c949ae9
to
94d8f62
Compare
|
Required status checks have been changed, could you please rebase this PR? |
bradkwadsworth-mw
force-pushed
the
feature/add-project-shared-vpc-resources
branch
from
94d8f62
to
6870ac1
Compare
bradkwadsworth-mw
requested review from
ulucinar and
sergenyalcin
as code owners
|
/test-examples="examples/compute/sharedvpchostproject.yaml" |
1 similar comment
|
/test-examples="examples/compute/sharedvpchostproject.yaml" |
bradkwadsworth-mw
force-pushed
the
feature/add-project-shared-vpc-resources
branch
from
4a4f20d
to
546a5e6
Compare
bradkwadsworth-mw
changed the title
added 7 commits
May 15, 2023 10:43
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
Signed-off-by: Brad Wadsworth <[email protected]>
bradkwadsworth-mw
force-pushed
the
feature/add-project-shared-vpc-resources
branch
from
546a5e6
to
afe2e2f
Compare
|
Closing & reopening to trigger the Github workflow runs. |
|
/test-examples="examples/compute/sharedvpchostproject.yaml" |
turkenh
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Enabledgoogle_compute_shared_vpc_host_projectandgoogle_compute_shared_vpc_service_project. It would appear thatgoogle_compute_shared_vpc_service_projectrequires thegoogle-betaprovider in order to work in some situations such as when the Shared VPC Admin role is set at the folder level. Has there been an discussion on creating another Upjet provider based on thegoogle-betaTerraform provider?Added host project and service project selectors for SharedVPCHostProject and SharedVPCServiceProject resources.
Fixes #80
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested the creation of a GCP project and enabled that project as a VPC host project. Also created a service project and attached it to the host project.
