Adding google_compute_backend_service_signed_url_key, google_compute_network_firewall_policy, google_compute_network_firewall_policy_association, google_compute_region_network_firewall_policy, google_compute_region_network_firewall_policy_association, google_compute_snapshot, google_compute_ssl_policy, google_eventarc_channel, google_eventarc_google_channel_config to v1beta1 version #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-examples="examples/compute/networkfirewallpolicy.yaml" |
|
/test-examples="examples/compute/regionnetworkfirewallpolicy.yaml" |
|
/test-examples="examples/compute/backendservicesignedurlkey.yaml" |
|
/test-examples="examples/compute/snapshot.yaml" |
|
/test-examples="examples/compute/sslpolicy.yaml" |
|
/test-examples="examples/eventarc/channel.yaml" |
|
/test-examples="examples/eventarc/googlechannelconfig.yaml" |
|
/test-examples="examples/compute/networkfirewallpolicyassociation.yaml" |
|
/test-examples="examples/compute/regionnetworkfirewallpolicyassociation.yaml" |
sergenyalcin
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding
compute7 resources to v1beta1 versionAdding
eventarc2 resources to v1beta1 versionFixes #175
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manual & Uptest:
google_compute_backend_service_signed_url_key - https://github.com/upbound/provider-gcp/actions/runs/4065889389
google_compute_network_firewall_policy - https://github.com/upbound/provider-gcp/actions/runs/4065874762
google_compute_network_firewall_policy_association - https://github.com/upbound/provider-gcp/actions/runs/4065936252
google_compute_region_network_firewall_policy - https://github.com/upbound/provider-gcp/actions/runs/4065880303
google_compute_region_network_firewall_policy_association - https://github.com/upbound/provider-gcp/actions/runs/4065953661
google_compute_snapshot - https://github.com/upbound/provider-gcp/actions/runs/4065895131
google_compute_ssl_policy - https://github.com/upbound/provider-gcp/actions/runs/4065901869
google_eventarc_channel - https://github.com/upbound/provider-gcp/actions/runs/4065907277
google_eventarc_google_channel_config - https://github.com/upbound/provider-gcp/actions/runs/4065911655