Adding google_monitoring_custom_service, google_monitoring_dashboard, google_monitoring_group, google_monitoring_metric_descriptor, google_monitoring_slo resources to v1beta1 version #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykolalosev
force-pushed
the
issue-151
branch
from
a53e2ee
to
a8d0622
Compare
|
/test-examples="examples/monitoring/customservice.yaml" |
|
/test-examples="examples/monitoring/dashboard.yaml" |
|
/test-examples="examples/monitoring/group.yaml" |
|
/test-examples="examples/monitoring/metricdescriptor.yaml" |
|
/test-examples="examples/monitoring/slo.yaml" |
sergenyalcin
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding monitoring (5) resources to v1beta1 version
google_monitoring_custom_servicegoogle_monitoring_dashboardgoogle_monitoring_groupgoogle_monitoring_metric_descriptorgoogle_monitoring_sloFixes #151
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manual & Uptest:
google_monitoring_custom_service - https://github.com/upbound/provider-gcp/actions/runs/3986850853
google_monitoring_dashboard - https://github.com/upbound/provider-gcp/actions/runs/3986870804
google_monitoring_group - https://github.com/upbound/provider-gcp/actions/runs/3986883854
google_monitoring_metric_descriptor - https://github.com/upbound/provider-gcp/actions/runs/3986891527
google_monitoring_slo - https://github.com/upbound/provider-gcp/actions/runs/3986912240