Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding google_dataproc_autoscaling_policy, google_dataproc_cluster, google_dataproc_job, google_dataproc_workflow_template to v1beta1 version #153

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

mykolalosev
Copy link
Contributor

@mykolalosev mykolalosev commented Jan 20, 2023

Description of your changes

Adding dataproc 4 resources to v1beta1 version

Fixes #131

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manual & Uptest:
google_dataproc_autoscaling_policy - https://github.com/upbound/provider-gcp/actions/runs/3967355097
google_dataproc_cluster - https://github.com/upbound/provider-gcp/actions/runs/3967361753
google_dataproc_job - https://github.com/upbound/provider-gcp/actions/runs/3967454653
google_dataproc_workflow_template - https://github.com/upbound/provider-gcp/actions/runs/3967369862

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/dataproc/autoscalingpolicy.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/dataproc/cluster.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/dataproc/workflowtemplate.yaml"

@mykolalosev
Copy link
Contributor Author

/test-examples="examples/dataproc/job.yaml"

Copy link
Collaborator

@sergenyalcin sergenyalcin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mykolalosev LGTM!

@mykolalosev mykolalosev merged commit 564ddc2 into crossplane-contrib:main Jan 23, 2023
@mykolalosev mykolalosev deleted the issue-131 branch January 23, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving dataproc (4) resources to v1beta1 version
2 participants