Add configuration of logging (13), memcache (1), mlengine (1), monitoring (5), network (2), networkmanagement (1), networkservices (3), notebooks (5) groups #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring (5), network (2), networkmanagement (1), networkservices (3), notebooks (5) groups
sergenyalcin
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add configuration of 13 resources in the
logginggroup:google_logging_billing_account_exclusiongoogle_logging_billing_account_sinkgoogle_logging_folder_bucket_configgoogle_logging_folder_exclusiongoogle_logging_folder_sinkgoogle_logging_log_viewgoogle_logging_metricgoogle_logging_organization_bucket_configgoogle_logging_organization_exclusiongoogle_logging_organization_sinkgoogle_logging_project_bucket_configgoogle_logging_project_exclusiongoogle_logging_project_sinkAdd configuration of 1 resources in the
memcachegroup:google_memcache_instanceAdd configuration of 1 resources in the
mlenginegroup:google_ml_engine_modelAdd configuration of 5 resources in the
monitoringgroup:google_monitoring_custom_servicegoogle_monitoring_dashboardgoogle_monitoring_groupgoogle_monitoring_metric_descriptorgoogle_monitoring_sloAdd configuration of 2 resources in the
networkgroup:google_network_connectivity_hubgoogle_network_connectivity_spokeAdd configuration of 1 resources in the
networkmanagementgroup:google_network_management_connectivity_testAdd configuration of 3 resources in the
networkservicesgroup:google_network_services_edge_cache_keysetgoogle_network_services_edge_cache_origingoogle_network_services_edge_cache_serviceAdd configuration of 5 resources in the
notebooksgroup:Fixes #17
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested