Bump Terraform provider version to v3.95.0 #668

turkenf · 2024-03-12T11:39:04Z

Description of your changes

In this PR:

Upgraded Terraform provider version to v3.95.0
Bump crossplane/upjet to the commit 363f66c52d2c
Added new required parameter connectionSetting for LabServiceLab.labservices.azure.upbound.io/v1beta1
Added removed references for WorkspaceCustomerManagedKey.databricks.azure.upbound.io/v1beta1. This resource has been deprecated and will be removed from the 4.0 Azure provider. Instead, the newly added WorkspaceRootDbfsCustomerManagedKey resource will be used ⬇️
Added new resource WorkspaceRootDbfsCustomerManagedKey.databricks.azure.upbound.io/v1beta1
Removed deprecated parameter siteNames and added site parameter to the BotChannelWebChat.botservice.azure.upbound.io/v1beta1resource. These parameters have been moved to LateInitializer IgnoredFields to prevent the update loop. Added description for the siteNames parameter that has been deprecated.
Fixed/changed external-name configurations for the following resources:
- AppServicePlan.web.azure.upbound.io/v1beta1
- ServicePlan.web.azure.upbound.io/v1beta1
- API.apimanagement.azure.upbound.io/v1beta1
- APIOperationPolicy.apimanagement.azure.upbound.io/v1beta1
- APIPolicy.apimanagement.azure.upbound.io/v1beta1
- Policy.apimanagement.azure.upbound.io/v1beta1
- ProductPolicy.apimanagement.azure.upbound.io/v1beta1
- WebApplicationFirewallPolicy.network.azure.upbound.io/v1beta1

I have:

Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Test details of resources with Breaking CRD schema changes and Native schema version changes have been added to the comment line below.

The newly added resource WorkspaceRootDbfsCustomerManagedKey.databricks.azure.upbound.io/v1beta1 has been tested manually

NAME                                                                                 SYNCED   READY   EXTERNAL-NAME
                                                                                AGE
workspacerootdbfscustomermanagedkey.databricks.azure.upbound.io/example-managedkey   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/e
xample-managedkey/providers/Microsoft.Databricks/workspaces/example-workspace   9m30s

turkenf · 2024-03-12T12:29:56Z

Breaking CRD schema changes

package/crds/apimanagement.azure.upbound.io_loggers.yaml Manually Tested ✅

NAME                                            SYNCED   READY   EXTERNAL-NAME   AGE
logger.apimanagement.azure.upbound.io/example   True     True    example         4m27s

package/crds/automation.azure.upbound.io_hybridrunbookworkergroups.yaml Manually Tested ✅

NAME                                                           SYNCED   READY   EXTERNAL-NAME
                                                                               AGE
hybridrunbookworkergroup.automation.azure.upbound.io/hrbwgex   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/hrbwgex/providers/Micro
soft.Automation/automationAccounts/hrbwgex/hybridRunbookWorkerGroups/hrbwgex   6m59s

package/crds/botservice.azure.upbound.io_botchannelwebchats.yaml Manually Tested ✅

NAME                                                             SYNCED   READY   EXTERNAL-NAME
                                                                                                      AGE
botchannelwebchat.botservice.azure.upbound.io/channel-web-chat   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/bot-resource-group-th
u-t/providers/Microsoft.BotService/botServices/bottChannelsRegistrationName/channels/WebChatChannel   5m15s

package/crds/databricks.azure.upbound.io_workspacecustomermanagedkeys.yaml Manually Tested ✅

NAME                                                                   SYNCED   READY   EXTERNAL-NAME
                                                              AGE
workspacecustomermanagedkey.databricks.azure.upbound.io/example-test   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/examplebricksrg
/providers/Microsoft.Databricks/workspaces/exampleworkspace   5m44s

package/crds/dbforpostgresql.azure.upbound.io_flexibleservers.yaml Manually Tested ✅

NAME                                                                SYNCED   READY   EXTERNAL-NAME       AGE
flexibleserver.dbforpostgresql.azure.upbound.io/example-test-3-95   True     True    example-test-3-95   24m

package/crds/labservices.azure.upbound.io_labservicelabs.yaml Manually Tested ✅

NAME                                                        SYNCED   READY   EXTERNAL-NAME    AGE
labservicelab.labservices.azure.upbound.io/example-twat-3   True     True    example-twat-3   7m36s

package/crds/web.azure.upbound.io_linuxwebapps.yaml Manually Tested ✅

NAME                                               SYNCED   READY   EXTERNAL-NAME     AGE
linuxwebapp.web.azure.upbound.io/linuxappexample   True     True    linuxappexample   5m46s

package/crds/web.azure.upbound.io_linuxwebappslots.yaml Manually Tested ✅

NAME                                                     SYNCED   READY   EXTERNAL-NAME
                                                                  AGE
linuxwebappslot.web.azure.upbound.io/lnxappslotexample   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/linuxwebappslot-rg/providers/
Microsoft.Web/sites/linuxwebappslot-lwa/slots/lnxappslotexample   12m

package/crds/web.azure.upbound.io_windowswebapps.yaml Manually Tested ✅

NAME                                                   SYNCED   READY   EXTERNAL-NAME       AGE
windowswebapp.web.azure.upbound.io/windowswebappname   True     True    windowswebappname   5m27s

package/crds/web.azure.upbound.io_windowswebappslots.yaml Manually Tested ✅

NAME                                             SYNCED   READY   EXTERNAL-NAME   AGE
windowswebappslot.web.azure.upbound.io/example   True     True    example         6m47s

Native schema version changes

azurerm_api_management_api Manually Tested ✅

NAME                                             SYNCED   READY   EXTERNAL-NAME   AGE
api.apimanagement.azure.upbound.io/example-api   True     True    example-api     8m19s

azurerm_api_management_api_operation_policy Manually Tested ✅

NAME                                                        SYNCED   READY   EXTERNAL-NAME
                                                                                                                          AGE
apioperationpolicy.apimanagement.azure.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/uptest-resourcegroup-examp
le/providers/Microsoft.ApiManagement/service/uptest-management-example-ft/apis/example-api/operations/acctest-operation   5m17

azurerm_api_management_api_policy Manually Tested ✅

NAME                                               SYNCED   READY   EXTERNAL-NAME
                                                                                    AGE
apipolicy.apimanagement.azure.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/uptest-resourcegroup-example/provid
ers/Microsoft.ApiManagement/service/uptest-management-example-ft/apis/example-api   5m14

azurerm_api_management_gateway_api Manually Tested ✅
azurerm_api_management_policy Manually Tested ✅

NAME                                            SYNCED   READY   EXTERNAL-NAME
                                                                AGE
policy.apimanagement.azure.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/uptest-resourcegroup-example/providers
/Microsoft.ApiManagement/service/uptest-management-example-ft   7m29s

azurerm_api_management_product_policy Manually Tested ✅

NAME                                                   SYNCED   READY   EXTERNAL-NAME
                                                                                           AGE
productpolicy.apimanagement.azure.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/uptest-resourcegroup-example/pr
oviders/Microsoft.ApiManagement/service/uptest-management-example-ft/products/my-product   7m27s

azurerm_app_service_plan Manually Tested ✅

NAME                                                       SYNCED   READY   EXTERNAL-NAME          AGE
appserviceplan.web.azure.upbound.io/appserviceplansample   True     True    appserviceplansample   11m

azurerm_linux_function_app Manually Tested ✅

NAME                                                  SYNCED   READY   EXTERNAL-NAME
                              AGE
linuxfunctionapp.web.azure.upbound.io/linuxappexmpl   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/linuxfuncapp-rg/providers/Micros
oft.Web/sites/linuxappexmpl   11m

azurerm_linux_function_app_slot Manually Tested ✅

NAME                                                       SYNCED   READY   EXTERNAL-NAME    AGE
linuxfunctionappslot.web.azure.upbound.io/examplelinslot   True     True    examplelinslot   7m39s

azurerm_linux_web_app Manually Tested ✅

NAME                                               SYNCED   READY   EXTERNAL-NAME     AGE
linuxwebapp.web.azure.upbound.io/linuxappexample   True     True    linuxappexample   5m46s

azurerm_linux_web_app_slot Manually Tested ✅

NAME                                                     SYNCED   READY   EXTERNAL-NAME
                                                                  AGE
linuxwebappslot.web.azure.upbound.io/lnxappslotexample   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/linuxwebappslot-rg/providers/
Microsoft.Web/sites/linuxwebappslot-lwa/slots/lnxappslotexample   12m

azurerm_maintenance_assignment_dedicated_host Manually Tested ✅

NAME                                                                        SYNCED   READY   EXTERNAL-NAME
                                                                                                                                     AGE
maintenanceassignmentdedicatedhost.maintenance.azure.upbound.io/example-2   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/maintenanc
ehost/providers/Microsoft.Compute/hostGroups/tester/hosts/example/providers/Microsoft.Maintenance/configurationAssignments/example   6m35s

azurerm_maintenance_assignment_virtual_machine Manually Tested ✅

NAME                                                                       SYNCED   READY   EXTERNAL-NAME
                                                                                                                          AGE
maintenanceassignmentvirtualmachine.maintenance.azure.upbound.io/example   True     True   /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/rgmaintenan
ce/providers/Microsoft.Compute/virtualMachines/example/providers/Microsoft.Maintenance/configurationAssignments/example   24m

azurerm_security_center_setting Manually Tested ✅

NAME                                                      SYNCED   READY   EXTERNAL-NAME
      AGE
securitycentersetting.security.azure.upbound.io/example   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/providers/Microsoft.Security/settings/Senti
nel   9m1s

azurerm_service_plan Manually Tested ✅

NAME                                              SYNCED   READY   EXTERNAL-NAME    AGE
serviceplan.web.azure.upbound.io/linuxwebapp-sp   True     True    linuxwebapp-sp

azurerm_spring_cloud_accelerator Manually Tested ✅

NAME                                                          SYNCED   READY   EXTERNAL-NAME
                                                                       AGE
springcloudaccelerator.appplatform.azure.upbound.io/default   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/scaexample/providers/Mic
rosoft.AppPlatform/spring/scaexample/applicationAccelerators/default   18m

azurerm_spring_cloud_customized_accelerator Manually Tested ✅

NAME                                                          SYNCED   READY   EXTERNAL-NAME
                                                                         AGE
springcloudaccelerator.appplatform.azure.upbound.io/default   True     True    /subscriptions/038f2b7c-3265-43b8-8624-c9ad5da610a8/resourceGroups/sccaexample/providers/Mi
crosoft.AppPlatform/spring/sccaexample/applicationAccelerators/default   51m

azurerm_storage_account Manually Tested ✅

NAME                                                    SYNCED   READY   EXTERNAL-NAME          AGE
account.storage.azure.upbound.io/linuxfuncnappslotacc   True     True    linuxfuncnappslotacc   10m

azurerm_web_application_firewall_policy Manually Tested ✅

NAME                                                            SYNCED   READY   EXTERNAL-NAME   AGE
webapplicationfirewallpolicy.network.azure.upbound.io/example   True     True    example         3m54s

azurerm_windows_function_app Manually Tested ✅

NAME                                                               SYNCED   READY   EXTERNAL-NAME              AGE
windowsfunctionapp.web.azure.upbound.io/windowsfunctionappnameaa   True     True    windowsfunctionappnameaa   30m

azurerm_windows_function_app_slot Manually Tested ✅

NAME                                                                SYNCED   READY   EXTERNAL-NAME           AGE
windowsfunctionappslot.web.azure.upbound.io/examplewinfuncappslot   True     True    examplewinfuncappslot   8m19s

azurerm_windows_web_app Manually Tested ✅

NAME                                                   SYNCED   READY   EXTERNAL-NAME       AGE
windowswebapp.web.azure.upbound.io/windowswebappname   True     True    windowswebappname   5m27s

azurerm_windows_web_app_slot Manually Tested ✅

NAME                                             SYNCED   READY   EXTERNAL-NAME   AGE
windowswebappslot.web.azure.upbound.io/example   True     True    example         6m47s

turkenf · 2024-03-12T12:32:59Z

/test-examples="examples/network/subnet.yaml"

turkenf · 2024-03-12T14:07:21Z

/test-examples="examples/network/subnet.yaml"

turkenf · 2024-03-12T14:33:53Z

/test-examples="examples/automation/hybridrunbookworkergroup.yaml"

turkenf · 2024-03-12T14:33:58Z

/test-examples="examples/recoveryservices/backuppolicyfileshare.yaml"

turkenf · 2024-03-12T14:34:03Z

/test-examples="examples/recoveryservices/backuppolicyvm.yaml"

turkenf · 2024-03-12T14:34:08Z

/test-examples="examples/storage/hpccache.yaml"

turkenf · 2024-03-12T15:47:21Z

/test-examples="examples/network/subnet.yaml"

turkenf · 2024-03-12T15:47:39Z

/test-examples="examples/automation/hybridrunbookworkergroup.yaml"

turkenf · 2024-03-12T17:00:04Z

/test-examples="examples/apimanagement/logger.yaml"

turkenf · 2024-03-12T17:03:46Z

/test-examples="examples/labservices/labserviceslab.yaml"

turkenf · 2024-03-12T17:04:43Z

/test-examples="examples/web/linuxwebapp.yaml"

turkenf · 2024-03-12T17:06:10Z

/test-examples="examples/web/windowswebapp.yaml"

turkenf · 2024-03-12T17:07:56Z

/test-examples="examples/web/appserviceplan.yaml"

turkenf · 2024-03-12T17:09:22Z

/test-examples="examples/web/functionapp.yaml"

turkenf · 2024-03-12T17:10:51Z

/test-examples="examples/security/securitycentersetting.yaml"

turkenf · 2024-03-12T17:12:12Z

/test-examples="examples/web/serviceplan.yaml"

turkenf · 2024-03-12T17:15:45Z

/test-examples="examples/appplatform/springcloudaccelerator.yaml"

turkenf · 2024-03-12T17:16:33Z

/test-examples="examples/appplatform/springcloudcustomizedaccelerator.yaml"

turkenf · 2024-03-12T17:17:44Z

/test-examples="examples/storage/accountlocaluser.yaml"

turkenf · 2024-03-12T20:48:16Z

/test-examples="examples/network/webapplicationfirewallpolicy.yaml"

turkenf · 2024-03-12T22:28:27Z

/test-examples="examples/automation/hybridrunbookworkergroup.yaml"

turkenf · 2024-03-21T11:37:03Z

/test-examples="examples/network/subnet.yaml"

Co-authored-by: Sergen Yalçın <[email protected]> Signed-off-by: Fatih Türken <[email protected]>

…ervices resource Signed-off-by: Fatih Türken <[email protected]>

- AppServicePlan.web.azure.upbound.io/v1beta1 - ServicePlan.web.azure.upbound.io/v1beta1 Signed-off-by: Fatih Türken <[email protected]>

…run make generate after rebase: - API.apimanagement.azure.upbound.io/v1beta1 - APIOperationPolicy.apimanagement.azure.upbound.io/v1beta1 - APIPolicy.apimanagement.azure.upbound.io/v1beta1 - Policy.apimanagement.azure.upbound.io/v1beta1 - ProductPolicy.apimanagement.azure.upbound.io/v1beta1 Signed-off-by: Fatih Türken <[email protected]>

…rk.azure.upbound.io/v1beta1 Signed-off-by: Fatih Türken <[email protected]>

… fix some comment lines Signed-off-by: Fatih Türken <[email protected]>

…e manifest Signed-off-by: Fatih Türken <[email protected]>

Signed-off-by: Fatih Türken <[email protected]>

…for deprecated field siteNames Signed-off-by: Fatih Türken <[email protected]>

…be deprecated. Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-03-21T13:02:03Z

/test-examples="examples/network/subnet.yaml"

…ff for GatewayAPI, APITag and APIRelease resources of apimanagement group Signed-off-by: Sergen Yalçın <[email protected]>

Signed-off-by: Fatih Türken <[email protected]>

turkenf · 2024-03-21T15:09:47Z

/test-examples="examples/network/subnet.yaml"

turkenf · 2024-03-21T15:11:08Z

/test-examples="examples/web/serviceplan.yaml"

Signed-off-by: Sergen Yalçın <[email protected]>

sergenyalcin

Thanks @turkenf LGTM!

turkenf · 2024-03-21T15:36:46Z

A local run of make lint has succeeded.

ulucinar

Thank you @sergenyalcin & @turkenf for this great effort!

rbrunan · 2024-03-21T15:55:07Z

Thank you folks, we really needed this!

turkenf force-pushed the update-tf-provider-3.95.0 branch from a8f4acd to 5ff88fd Compare March 12, 2024 12:03

turkenf force-pushed the update-tf-provider-3.95.0 branch 7 times, most recently from 78a1ca7 to bc976f4 Compare March 20, 2024 00:29

turkenf marked this pull request as ready for review March 21, 2024 00:34

turkenf requested review from ulucinar and sergenyalcin as code owners March 21, 2024 00:34

turkenf force-pushed the update-tf-provider-3.95.0 branch 2 times, most recently from 2c3d38c to b0853cf Compare March 21, 2024 11:36

turkenf and others added 10 commits March 21, 2024 15:53

Bump Terraform provider version to v3.95.0 and bump dependencies

f458fbf

Co-authored-by: Sergen Yalçın <[email protected]> Signed-off-by: Fatih Türken <[email protected]>

Add new required parameter 'connectionSetting' for LabServiceLab.labs…

87d9d6f

…ervices resource Signed-off-by: Fatih Türken <[email protected]>

Fix externalname configuration for:

d2ed5b0

- AppServicePlan.web.azure.upbound.io/v1beta1 - ServicePlan.web.azure.upbound.io/v1beta1 Signed-off-by: Fatih Türken <[email protected]>

Fix externalname configuration for WebApplicationFirewallPolicy.netwo…

9ff177c

…rk.azure.upbound.io/v1beta1 Signed-off-by: Fatih Türken <[email protected]>

Add removed references for WorkspaceCustomerManagedKey.databricks and…

aa16da2

… fix some comment lines Signed-off-by: Fatih Türken <[email protected]>

Configure WorkspaceRootDbfsCustomerManagedKey resource and add exampl…

ddb54a2

…e manifest Signed-off-by: Fatih Türken <[email protected]>

Bump upjet to the commit 50919febc5ab

875d90c

Signed-off-by: Fatih Türken <[email protected]>

Fix update loop for BotChannelWebChat.botservice and add description …

3d9cc5c

…for deprecated field siteNames Signed-off-by: Fatih Türken <[email protected]>

Add a description that the resource WorkspaceCustomerManagedKey will …

1ac71bf

…be deprecated. Signed-off-by: Fatih Türken <[email protected]>

turkenf force-pushed the update-tf-provider-3.95.0 branch from b0853cf to 1ac71bf Compare March 21, 2024 13:01

sergenyalcin and others added 2 commits March 21, 2024 17:49

Fix external name configuration of API.apimanagement and add CustomDi…

79d3c1b

…ff for GatewayAPI, APITag and APIRelease resources of apimanagement group Signed-off-by: Sergen Yalçın <[email protected]>

Remove deprecated fields and fix example for ApplicationGateway.network

503d832

Signed-off-by: Fatih Türken <[email protected]>

Add //nolint:gocyclo for custom diff function

cfe5c04

Signed-off-by: Sergen Yalçın <[email protected]>

sergenyalcin approved these changes Mar 21, 2024

View reviewed changes

ulucinar approved these changes Mar 21, 2024

View reviewed changes

turkenf merged commit 38c0ef4 into crossplane-contrib:main Mar 21, 2024
8 of 9 checks passed

turkenf deleted the update-tf-provider-3.95.0 branch March 21, 2024 15:41

ulucinar mentioned this pull request Mar 21, 2024

Bump native provider to version 3.80.0 #497

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Terraform provider version to v3.95.0 #668

Bump Terraform provider version to v3.95.0 #668

turkenf commented Mar 12, 2024 •

edited

Loading

turkenf commented Mar 12, 2024 •

edited

Loading

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 21, 2024

turkenf commented Mar 21, 2024

turkenf commented Mar 21, 2024

turkenf commented Mar 21, 2024

sergenyalcin left a comment

turkenf commented Mar 21, 2024

ulucinar left a comment

rbrunan commented Mar 21, 2024

Bump Terraform provider version to v3.95.0 #668

Bump Terraform provider version to v3.95.0 #668

Conversation

turkenf commented Mar 12, 2024 • edited Loading

Description of your changes

How has this code been tested

turkenf commented Mar 12, 2024 • edited Loading

Breaking CRD schema changes

Native schema version changes

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 12, 2024

turkenf commented Mar 21, 2024

turkenf commented Mar 21, 2024

turkenf commented Mar 21, 2024

turkenf commented Mar 21, 2024

sergenyalcin left a comment

Choose a reason for hiding this comment

turkenf commented Mar 21, 2024

ulucinar left a comment

Choose a reason for hiding this comment

rbrunan commented Mar 21, 2024

turkenf commented Mar 12, 2024 •

edited

Loading

turkenf commented Mar 12, 2024 •

edited

Loading