Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing apostrophe breaking a hyperlink #897

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

jastang
Copy link
Contributor

@jastang jastang commented Sep 28, 2023

Description of your changes

Fixes https://github.com/upbound/squad-upbound-cloud/issues/1295, where a link in the Upbound console is broken due to an extra character in auth.yaml.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

N/A

@ulucinar
Copy link
Collaborator

ulucinar commented Oct 4, 2023

/test-examples="examples/ec2/vpc.yaml"

@ulucinar
Copy link
Collaborator

ulucinar commented Oct 4, 2023

Hi @jastang,
Triggered uptest to have a comparison between the monolith-based e2e tests and the family provider based ones, not to validate this PR :)

And thank you for the fix.

@jastang jastang merged commit 5d2d4f0 into main Oct 4, 2023
8 checks passed
@jastang jastang deleted the jastang-patch-1295 branch October 4, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants