Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve name collision between S3 and Lightsail in quickstart #811

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

mergenci
Copy link
Collaborator

@mergenci mergenci commented Aug 4, 2023

Description of your changes

Fix #590: S3 and Lightsail APIs have their own “buckets” resources. Quickstart document creates an S3 bucket. When kubectl get buckets command is run, though, Lightsail resources are listed. Such behavior confuses users, especially newcomers to crossplane, who expect to see their S3 buckets instead.

I have:

  • Run make reviewable test to ensure this PR is ready for review.

I couldn't run make reviewable test, because of IS#737. I hope that updating only documentation won't cause any problems.

How has this code been tested

I've followed quickstart document and manually run shell commands. I've used a local kind cluster.

@Upbound-CLA
Copy link

Upbound-CLA commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

@mergenci mergenci changed the title Fix 590 Resolve name collision between S3 and Lightsail in quickstart Aug 29, 2023
Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mergenci, LGTM.

@mergenci
Copy link
Collaborator Author

I wanted to run make reviewable test before merging, but it failed again 🤦‍♂️— this time for a different reason than above:

17:46:34 [ .. ] golangci-lint
WARN [runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.  
ERRO Timeout exceeded: try increasing it by passing --timeout option 
17:57:14 [FAIL]
make[2]: *** [go.lint] Error 1
make[1]: *** [lint] Error 2
make: *** [reviewable] Error 2

I'll merge without running it. Everything should be fine.

@mergenci mergenci merged commit 4ce6286 into crossplane-contrib:main Sep 29, 2023
8 checks passed
@mergenci mergenci deleted the fix-590 branch September 29, 2023 15:06
@mergenci mergenci mentioned this pull request Feb 26, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buckets: kubectl get buckets executes lightsail API
3 participants