Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pipes Support #1418

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Conversation

blakeromano
Copy link
Contributor

Description of your changes

Fixes #821

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

make e2e UPTEST_EXAMPLE_LIST=examples/pipes/pipe.yaml

Output:

k get managed
NAME                              SYNCED   READY   EXTERNAL-NAME   AGE
role.iam.aws.upbound.io/example   True     True    example         100s

NAME                                   SYNCED   READY   EXTERNAL-NAME   AGE
rolepolicy.iam.aws.upbound.io/source   True     True    source          100s
rolepolicy.iam.aws.upbound.io/target   True     True    target          100s

NAME                                SYNCED   READY   EXTERNAL-NAME   AGE
pipe.pipes.aws.upbound.io/example   True     True    example         62s

NAME                              SYNCED   READY   EXTERNAL-NAME                                                                           AGE
queue.sqs.aws.upbound.io/source   True     True    https://sqs.us-west-1.amazonaws.com/ACCOUNT/terraform-20240724154050499100000003   100s
queue.sqs.aws.upbound.io/target   True     True    https://sqs.us-west-1.amazonaws.com/ACCOUNT/terraform-20240724154050506300000004   100s
=== CONT  kuttl
    harness.go:402: run tests finished
    harness.go:511: cleaning up
    harness.go:553: skipping cluster tear down
    harness.go:554: to connect to the cluster, run: export KUBECONFIG="/Users/blake.romano/code/provider-aws/kubeconfig"
--- PASS: kuttl (123.93s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (123.00s)
PASS
08:42:51 [ OK ] running automated tests

Signed-off-by: Blake R <[email protected]>
Signed-off-by: Blake R <[email protected]>
@jeanduplessis
Copy link
Collaborator

/test-examples="examples/pipes/pipe.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your effort @blakeromano, left two small comments for you to consider.

examples/pipes/pipe.yaml Outdated Show resolved Hide resolved
examples/pipes/pipe.yaml Outdated Show resolved Hide resolved
Signed-off-by: Blake R <[email protected]>
@turkenf
Copy link
Collaborator

turkenf commented Jul 25, 2024

/test-examples="examples/pipes/v1beta1/pipe.yaml"

Uptest run https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10101985094

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@turkenf turkenf merged commit 740511c into crossplane-contrib:main Jul 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for aws_pipes_pipe resource
3 participants