-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aws_ec2_fleet resource #1405
Conversation
/test-examples="examples/ec2/v1beta1/fleetrequest.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your effort @teabot, I left a few comments for you to consider.
Thanks for the feedback @turkenf. I have applied the changes requested. Note that in this providers, the existing spot fleet nomeclature includes a |
/test-examples="examples/ec2/v1beta1/fleetrequest.yaml" |
/test-examples="examples/ec2/v1beta1/fleet.yaml" |
/test-examples="examples/ec2/v1beta1/fleet.yaml" |
This example passes local upsets, however I notice the following issues, and would appreciate help solving them:
cc. @turkenf |
/test-examples="examples/ec2/v1beta1/fleet.yaml" |
@turkenf Is anything else required here? |
Thank you very much for your interest @teabot. About the issues and solutions you noticed in this comment, let's open the issues and discuss them there. There is already an issue with missing reference, you can open issues for other ones. I think these issues are not a blocker for us to move this PR forward. |
And please run |
Done |
fe8ee30
to
a57a3d4
Compare
/test-examples="examples/ec2/v1beta1/fleet.yaml" Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10283336838 |
Signed-off-by: Elliot West <[email protected]> Update examples/ec2/v1beta1/fleetrequest.yaml Co-authored-by: Fatih Türken <[email protected]> Signed-off-by: Elliot West <[email protected]> Update examples/ec2/v1beta1/fleetrequest.yaml Co-authored-by: Fatih Türken <[email protected]> Signed-off-by: Elliot West <[email protected]> Update examples/ec2/v1beta1/fleetrequest.yaml Co-authored-by: Fatih Türken <[email protected]> Signed-off-by: Elliot West <[email protected]> Passing fleet Signed-off-by: Elliot West <[email protected]>
Signed-off-by: Elliot West <[email protected]>
Signed-off-by: Elliot West <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
Description of your changes
Added
aws_ec2_fleet
resource to the provider.Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR if necessary.How has this code been tested
Local run of uptest: