-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate enableExternalSecretStores option #124
Conversation
Signed-off-by: ZhengjunHUO <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great, thanks a lot @ZhengjunHUO
Is it possible to extend the documentation(README) with the brief documentation of ExternalSecretStore support?
Signed-off-by: ZhengjunHUO <[email protected]>
@ytsarev sure thing, you're right, it could be helpful for those who are interested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks a lot @ZhengjunHUO!
@ZhengjunHUO I hope you’re doing well! My name is Jean and I’m an Engineering Manager at Upbound. As Upbound, we’re preparing to add |
@jeanduplessis it's done, it's always a pleasure to contribute to the community. |
Thank you @ZhengjunHUO 🙏🏻 |
Signed-off-by: ZhengjunHUO [email protected]
Description of your changes
Fixes #100
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Cherry picked from PR #101 for release-0.3