Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate enableExternalSecretStores option #124

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

ZhengjunHUO
Copy link
Contributor

Signed-off-by: ZhengjunHUO [email protected]

Description of your changes

Fixes #100

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Cherry picked from PR #101 for release-0.3

Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great, thanks a lot @ZhengjunHUO

Is it possible to extend the documentation(README) with the brief documentation of ExternalSecretStore support?

@ZhengjunHUO
Copy link
Contributor Author

@ytsarev sure thing, you're right, it could be helpful for those who are interested.

Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks a lot @ZhengjunHUO!

@ytsarev ytsarev merged commit 60a44aa into crossplane-contrib:master Nov 4, 2022
@jeanduplessis
Copy link

@ZhengjunHUO I hope you’re doing well! My name is Jean and I’m an Engineering Manager at Upbound. As Upbound, we’re preparing to add crossplane-contrib/provider-terraform to our Official Provider program, which will make it part of the providers Upbound officially supports and maintains. The goal of this program is to help converge the Crossplane community’s efforts around a single set of high-quality providers. This will reduce confusion around what provider to use and accelerate project adoption. It will continue to be open source under the Apache 2.0 license, similar to the current provider but will live under the Upbound organization in GitHub and requires contributors to sign a CLA for contributions. You have some commits in crossplane-contrib/provider-terraform, including this PR, which we appreciate and would like to include in the upbound/provider-terraform official provider, too, so I’d like to ask you to sign the CLA here so we can include your contribution in the official provider. We’d also love for you to continue to contribute to the provider in its new home in the upbound org on GitHub to help us to continue supporting the community. Let me know if you have any further questions.

@ZhengjunHUO
Copy link
Contributor Author

@jeanduplessis it's done, it's always a pleasure to contribute to the community.

@jeanduplessis
Copy link

Thank you @ZhengjunHUO 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable external secret store to publish secret to Vault
3 participants