Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for terraform insecure flag #112

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat: Add support for terraform insecure flag #112

merged 1 commit into from
Jun 11, 2024

Conversation

FCosta999
Copy link
Contributor

Description of your changes

This MR will support the addition of insecure flag.

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make submodules; make reviewable test to ensure this PR is ready for review.

Copy link
Collaborator

@schlakob schlakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlakob schlakob merged commit 2296b86 into crossplane-contrib:main Jun 11, 2024
7 checks passed
@FCosta999
Copy link
Contributor Author

Hi @schlakob,

can you generate a new release please?

@FCosta999 FCosta999 deleted the insecure-support branch June 11, 2024 12:03
@jan-di
Copy link
Collaborator

jan-di commented Jun 11, 2024

Would you be so kind and test this before we release the new version?

The provider including this PR is already available at:
xpkg.upbound.io/crossplane-contrib/provider-openstack:v0.3.0-57.g2296b86

@FCosta999
Copy link
Contributor Author

Hi @jan-di,
just tested and it worked perfectly.

By adding the option "insecure": "true" to my provider config the error message for tls: failed to verify certificate: x509: certificate signed by unknown authority disappeared and my resource was created successfully.

Thank you both for the timely response.

@jan-di
Copy link
Collaborator

jan-di commented Jun 11, 2024

Thank you! We will do a release :)

@schlakob
Copy link
Collaborator

Just released the v0.4.0.

https://marketplace.upbound.io/providers/crossplane-contrib/provider-openstack/v0.4.0

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants