Support to Add, Remove and List ACLs (Fixes #6)

internal/clients/kafka/acl/acl.go

@@ -161,21 +161,6 @@ func Generate(name string, params *v1alpha1.AccessControlListParameters) *Access
 	return acl
 }
 
-// LateInitializeSpec fills empty ACL spec fields with the data retrieved from Kafka.
-func LateInitializeSpec(in *v1alpha1.AccessControlListParameters, observed *AccessControlList) bool {
-	lateInitialized := false
-
-	in.Principle = observed.Principle
-	in.Operation = observed.Operation
-	in.ResourceType = observed.ResourceType
-	in.PermissionType = observed.PermissionType
-	in.ResourcePatternTypeFilter = observed.ResourcePatternTypeFilter
-
-	lateInitialized = true
-
-	return lateInitialized
-}
-
 // IsUpToDate returns true if the supplied Kubernetes resource differs from the
 // supplied Kafka ACLs.
 func IsUpToDate(in *v1alpha1.AccessControlListParameters, observed *AccessControlList) bool {

internal/controller/acl/acl.go

@@ -51,6 +51,7 @@ const (
 	errGetCreds             = "cannot get credentials"
 	errListACL              = "cannot List ACLs"
 	errNewClient            = "cannot create new Service"
+	errUpdateNotSupported	= "upadtes are not supported"
 )
 
 // Setup adds a controller that reconciles AccessControlList managed resources.
@@ -142,14 +143,11 @@ func (c *external) Observe(ctx context.Context, mg resource.Managed) (managed.Ex
 
 	extname, err := acl.ConvertFromJSON(meta.GetExternalName(cr))
 	compare := acl.CompareAcls(*extname, *acl.Generate(cr.Name, &cr.Spec.ForProvider))
-
-	lateInitialized := acl.LateInitializeSpec(&cr.Spec.ForProvider, extname)
-
+
 	if !compare {
 		return managed.ExternalObservation{
 			ResourceExists:          true,
-			ResourceUpToDate:        true, // acl.IsUpToDate(&cr.Spec.ForProvider, extname),
-			ResourceLateInitialized: lateInitialized,
+			ResourceUpToDate:        false,
 		}, errors.Wrap(err, "Updating not allowed")
 	}
 
@@ -194,7 +192,7 @@ func (c *external) Create(ctx context.Context, mg resource.Managed) (managed.Ext
 
 func (c *external) Update(ctx context.Context, mg resource.Managed) (managed.ExternalUpdate, error) {
 
-	return managed.ExternalUpdate{}, errors.New("Updates are not supported")
+	return managed.ExternalUpdate{}, errors.New(errUpdateNotSupported)
 }
 
 func (c *external) Delete(ctx context.Context, mg resource.Managed) error {