Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable MaxConcurrentReconciles with a better default for max-reconcile-rate #211

Merged

Conversation

turkenh
Copy link
Collaborator

@turkenh turkenh commented Feb 20, 2024

Description of your changes

This PR:

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

See crossplane-contrib/provider-kubernetes#203

@turkenh turkenh changed the title Use better defaults for poll interval and max reconcile rate Configurable MaxConcurrentReconciles with a better default for max-reconcile-rate Feb 20, 2024
@turkenh turkenh requested review from negz and lsviben February 20, 2024 08:56
@lsviben
Copy link
Collaborator

lsviben commented Feb 20, 2024

Looks ok but not sure why the e2e test is failing. Is it broken? Ill try to debug locally, but I see same thing is happening on master

@turkenh
Copy link
Collaborator Author

turkenh commented Feb 20, 2024

Looks ok but not sure why the e2e test is failing. Is it broken? Ill try to debug locally, but I see same thing is happening on master

@lsviben my other PR could be fixing it: 27b35cc

Working on making it up to date as you suggested, then we can rebase this one.

Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
@turkenh turkenh merged commit 3bfbd5f into crossplane-contrib:master Feb 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants