Support configurable reconcile rates #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2021
Signed-off-by: Nic Cope <[email protected]>
Partially addresses crossplane/crossplane#2595 Signed-off-by: Nic Cope <[email protected]>
The default in controller-runtime is to use the 'configmapsleases' strategy, which takes a lock using both a ConfigMap and a Lease. This is done for backward compatibility. For reasons that are not immediately clear to me (presumably some kind of saturation) we find that at --max-reconcile-rate=100 we start to see leadership losses because we can't renew our lease before the 10 second renewal deadline is up. This should be a safe change since we've been using configmapleases for many releases, so I don't expect dropping configmaps to affect anyone. (We also don't create more than one replica by default.) Signed-off-by: Nic Cope <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Partially addresses crossplane/crossplane#2595 - see that issue for details.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I tested this together with crossplane/crossplane#2602. See crossplane/crossplane#2568 (comment) for details.