Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant gcp folders #38

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Remove redundant gcp folders #38

merged 1 commit into from
Sep 30, 2019

Conversation

soorena776
Copy link
Contributor

Signed-off-by: soorena776 [email protected]

Description of your changes

Similar fix to crossplane-contrib/provider-aws#26 for gcp stack

  • removing unnecessary gcp directories
  • changing the image's binary name from crossplane to stack

Checklist

I have:

  • Run make reviewable to ensure this PR is ready for review.
  • Ensured this PR contains a neat, self documenting set of commits.
  • Updated any relevant documentation, examples, or release notes.
  • Updated the RBAC permissions in clusterrole.yaml to include any new types.

Signed-off-by: soorena776 <[email protected]>
@upbound-bot
Copy link
Collaborator

66% (0.0%) vs master 66%

Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this!

Copy link
Member

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @soorena776 ! I will likely follow this same pattern with crossplane-contrib/provider-azure#19

@jbw976 jbw976 merged commit bb47431 into crossplane-contrib:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants