Update build submodule and crossplane-tools #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
reviewed
May 2, 2021
Signed-off-by: Muvaffak Onus <[email protected]>
hasheddan
reviewed
May 2, 2021
There was a problem hiding this comment.
@muvaf failing here due to kind not allowing capital letters in cluster name, can be fixed by renaming INTTESTS to inttests here: https://github.com/crossplane/provider-gcp/pull/323/files#diff-b051933e1c5ed7533648af4517ede8d50df55b68a56c44e6094d3019595abcf2R147
Signed-off-by: Muvaffak Onus <[email protected]>
Signed-off-by: Muvaffak Onus <[email protected]>
hasheddan
approved these changes
May 2, 2021
Signed-off-by: Muvaffak Onus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update build submodule and crossplane-tools before the release.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
N/A