Complete AWS SDK v2 Migration #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <[email protected]>
turkenh
reviewed
Oct 4, 2021
| @@ -206,7 +206,7 @@ type EncryptionConfiguration struct { | |||
| // supports symmetric customer managed CMKs. For more information, see Using | |||
| // Symmetric and Asymmetric Keys (https://docs.aws.amazon.com/kms/latest/developerguide/symmetric-asymmetric.html) | |||
| // in the AWS Key Management Service Developer Guide. | |||
| ReplicaKmsKeyID string `json:"replicaKmsKeyId"` | |||
| ReplicaKmsKeyID *string `json:"replicaKmsKeyId"` | |||
There was a problem hiding this comment.
what is the reasoning behind these type changes. I see that some changed from pointer and some to a pointer.
There was a problem hiding this comment.
It's just what the new version of the SDK expects
Signed-off-by: Muvaffak Onus <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
There were a few things missing in #602 . This PR aims to fix those and updates the SDK to the latest version of v2 as of today along with crossplane-runtime.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Compiles,
make reviewableand unit tests.