fix(ecs): DesiredCount/RunningCount check #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Martins (bjm) <[email protected]>
bmartins-unit
force-pushed
the
fix-ecs-desiredCount-runningCount
branch
from
9d6d25f
to
acf33a2
Compare
MisterMX
changed the title
MisterMX
approved these changes
Sep 16, 2024
|
Successfully created backport PR #2092 for |
|
@MisterMX any idea when a tag will be created? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
The value of
DesiredCountandRunningCountare equal, so theConditionshould beAvailableI have:
make reviewable testto ensure this PR is ready for review.How has this code been tested