Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docdb): allow (major) version upgrades #2073

Conversation

wotolom
Copy link
Contributor

@wotolom wotolom commented Jul 4, 2024

Description of your changes

for DBCluster.docdb:

  • add allowMajorVersionUpgrade parameter to API (same update logic as for DBCluster.rds)
  • add check for engineVersion change (copied logic from rds)

Edit: 2nd commit:

  • adapt unit-tests
  • add engineVersion to observation
  • avoid sending unnecessary Modify-class while DBCluster being in modifying/upgrading states

I have:

  • Read and followed Crossplane's [contribution process].
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

manually

Signed-off-by: Charel Baum (external expert on behalf of DB InfraGO AG) <[email protected]>
@wotolom wotolom force-pushed the docdb-dbcluster-allow-major-version-upgrade branch from e30016c to 01a66db Compare July 24, 2024 11:56
v0.12.0 is not yet available.

Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
@MisterMX MisterMX force-pushed the docdb-dbcluster-allow-major-version-upgrade branch from 8dc8bfa to 39e2486 Compare July 24, 2024 12:19
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @wotolom!

@MisterMX MisterMX merged commit fc5dfe5 into crossplane-contrib:master Jul 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants