feat: add managed resource metrics #1964
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds two new metrics that can be used for exposing information about reconciliations and request to aws per managed resource:
Which is especially helpful for managed resources which use relatively expensive api calls, like service catalog.
This two metrics turn on by feature flag
--enable-managed-resource-metrics
or env variableENABLE_MANAGED_RESOURCE_METRICS
.For now these metrics are implemented only in ProvisionedProduct.
Metrics sample:
I have:
make reviewable test
to ensure this PR is ready for review.