fix(ec2): Update launchtemplate status #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Blatt (external expert on behalf of DB Netz) <[email protected]>
chlunde
approved these changes
Nov 7, 2023
MisterMX
force-pushed
the
fix/ec2-launchtemplate-status
branch
from
ac6c503 to
0d10c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds a step to
postObserveto fillstatus.atProviderwith the values received fromDescribeLaunchTemplates.Fixes #1936
This is kind of a hotfix to this solve the issue. The controller is still incomplete by missing an implementation for
isUpToDate. There are also some fields in the status (liketags) that should not be there and better belong in the spec.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Unit tests