fix(delete): recreate cluster when deleted via argocd-ui #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
force-pushed
the
fix/delete-argocd-ui
branch
from
1324b37 to
a859458
Compare
|
Thanks @haarchri! I think it would be cleaner to implement this via the newly added filtering to the cluster |
|
I'd like to straightforwardly address the current implementation with this pull request. Iam open to modifying it to a List endpoint for a v0.6.0 release in a seperate PR? |
janwillies
requested changes
Nov 30, 2023
Signed-off-by: Christopher Haar <[email protected]>
haarchri
force-pushed
the
fix/delete-argocd-ui
branch
from
16159d3 to
62f0c07
Compare
janwillies
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
this PR solves a problem where, upon a user's deletion of a cluster through argocd-ui, the provider would recreate the cluster instead of displaying a permission denied error.
Fixes #116
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested