Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distroless/static image instead of distroless/base since glibc is not used #49

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vilmosmartinek
Copy link

Description of your changes

This pull request changes the base image of the function to gcr.io/distroless/static-debian12:nonroot.

Fixes #48

I have:

  • Read and followed Crossplane's contribution process.
    - [ ] Added or updated unit tests for my change.

Copy link
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice @vilmosmartinek, this looks like a good improvement to make. Thank you for taking the initiative to do so 🙇‍♂️ - it's actually particularly on my mind as I just finished writing up the security self-assessment in crossplane/crossplane#6143 😉

I see that you've opened similar PRs across a few other function repos and also the template repo (crossplane/function-template-go#88), thank you for being thorough.

Let's see if we can get these all merged and new versions of the functions published.

Were you able to do some local testing already to build with this change and verify the function works well still? I don't think there's much in the way of e2e tests here that would test that automatically...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use distroless/static image instead of distroless/base since glibc is not used
2 participants