Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channel: discard messages eagerly #669

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

BusyJay
Copy link
Contributor

@BusyJay BusyJay commented Feb 28, 2021

If all receivers are dropped, the memory hold by channel will only be
dropped when all senders are also dropped. If there are too many
channels the memory leak can be significant.

If all receivers are dropped, the memory hold by channel will only be
dropped when all senders are also dropped. If there are too many
channels the memory leak can be significant.

Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 26, 2021

Build succeeded:

@bors bors bot merged commit 06d77d3 into crossbeam-rs:master Mar 26, 2021
@BusyJay BusyJay deleted the discard-messages-eargerly branch March 26, 2021 13:22
bors bot added a commit that referenced this pull request Apr 10, 2021
683: Prepare for the next release r=taiki-e a=taiki-e

Changes:

- crossbeam-channel 0.5.0 -> 0.5.1
  - Fix memory leak in unbounded channel. (#669)


Co-authored-by: Taiki Endo <[email protected]>
@taiki-e
Copy link
Member

taiki-e commented Apr 10, 2021

Published in crossbeam-channel 0.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants