Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit lazy_static version #429

Closed
wants to merge 2 commits into from
Closed

Limit lazy_static version #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
343ee9b
Limit lazy_static version
jeehoonkang Oct 15, 2019
00df844
Limit cfg-if version
jeehoonkang Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ std = [
alloc = ["crossbeam-epoch/alloc", "crossbeam-utils/alloc"]

[dependencies]
cfg-if = "0.1.2"
cfg-if = "~0.1.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I prefer to downgrade the dependency version with ci instead of limiting the version. (rayon did it before.)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taiki-e Would you be willing to submit a PR taking a similar strategy as in Rayon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit of #428 is doing that: b2e6cf8


[dependencies.crossbeam-channel]
version = "0.3.9"
Expand Down
4 changes: 2 additions & 2 deletions crossbeam-epoch/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ alloc = ["crossbeam-utils/alloc"]
sanitize = [] # Makes it more likely to trigger any potential data races.

[dependencies]
cfg-if = "0.1.2"
cfg-if = "~0.1.9"
memoffset = "0.5"

[dependencies.crossbeam-utils]
Expand All @@ -32,7 +32,7 @@ path = "../crossbeam-utils"
default-features = false

[dependencies.lazy_static]
version = "1"
version = "~1.3.0"
optional = true

[dependencies.scopeguard]
Expand Down
2 changes: 1 addition & 1 deletion crossbeam-skiplist/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ std = ["crossbeam-epoch/std", "crossbeam-utils/std"]
alloc = ["crossbeam-epoch/alloc", "crossbeam-utils/alloc"]

[dependencies]
cfg-if = "0.1.2"
cfg-if = "~0.1.9"

[dependencies.crossbeam-epoch]
version = "0.7"
Expand Down
4 changes: 2 additions & 2 deletions crossbeam-utils/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ std = ["lazy_static"]
alloc = []

[dependencies]
cfg-if = "0.1.2"
lazy_static = { version = "1.1.0", optional = true }
cfg-if = "~0.1.9"
lazy_static = { version = "~1.3.0", optional = true }

[dev-dependencies]
rand = "0.6"