Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly log tracebacks #613

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Mar 14, 2016

The first argument to log.critical() is actually the format-string -- so if a traceback itself contains {}'s then this becomes a "cannot format log message" error.

@codecov-io
Copy link

Current coverage is 57.34%

Merging #613 into master will not affect coverage as of 199d61f

@@            master    #613   diff @@
======================================
  Files           61      61       
  Stmts        10238   10238       
  Branches      1664    1664       
  Methods          0       0       
======================================
  Hit           5871    5871       
  Partial        556     556       
  Missed        3811    3811       

Review entire Coverage Diff as of 199d61f

Powered by Codecov. Updated on successful CI builds.

oberstet pushed a commit that referenced this pull request Mar 15, 2016
@oberstet oberstet merged commit a9c3451 into crossbario:master Mar 15, 2016
@meejah meejah deleted the tracebacks-from-onmessage branch March 31, 2016 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants