Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use structured debug logging, and wrap JSON payloads in repr() #606

Merged
merged 2 commits into from
Feb 26, 2016

Conversation

meejah
Copy link
Contributor

@meejah meejah commented Feb 25, 2016

This is a fix for #599 which also fixes the debug-logging from frames to use structured-style logging -- since we already special-cased JSON payloads (opcode == 1) this just wraps those in a repr() so they're properly escaped (and also easy to copy/paste now).

@codecov-io
Copy link

Current coverage is 57.34%

Merging #606 into master will increase coverage by +0.01% as of 01f332d

@@            master    #606   diff @@
======================================
  Files           61      61       
  Stmts        10240   10238     -2
  Branches      1664    1664       
  Methods          0       0       
======================================
  Hit           5871    5871       
  Partial        556     556       
+ Missed        3813    3811     -2

Review entire Coverage Diff as of 01f332d

Powered by Codecov. Updated on successful CI builds.

oberstet pushed a commit that referenced this pull request Feb 26, 2016
use structured debug logging, and wrap JSON payloads in repr()
@oberstet oberstet merged commit a7c3ca3 into crossbario:master Feb 26, 2016
@meejah meejah deleted the 599-frame-logging branch March 2, 2016 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants