Update emscripten #230
Update emscripten #230
Conversation
rustc switched to emscripten with LLVM 6. emscripten versions with LLVM 4 are not supported anymore. This upgrades emscripten to the same version as rustc is using in its CI.
CryZe
requested review from
Dylan-DPC-zz,
jamesmunns and
a team
as code owners
|
Thanks @CryZe bors: try |
|
bors: try |
tryNot awaiting review |
tryBuild failed |
|
So it seems like there's some spurious errors in here. But there's an actual problem with my PR in that the CI uses an old rust compiler for the wasm32-unknown-emscripten target due to rust-lang/cargo#4689 |
Disasm
added
the
S-blocked
|
I would want this to be fixed, but in order for that to happen, the rustc version in the test needs to be bumped. However it is explicitly set to an old version, because cargo run is apparently broken with emscripten files in more recent rust versions. Can I just kill the cross run for the emscripten target and then this can be merged or how should this progress? (I find it highly unlikely that anyone fixes this problem on rust's side anytime soon as the emscripten targets are close to being unsupported with the verge of the unknown target. And cross's emscripten targets are completely broken until then if this isn't merged). |
|
Can somebody tell me if I can just remove the tests for that target? The target is on the verge of dying anyway, so it's unlikely that anyone fixes the test runner bugs anytime soon. So I'd rather have this merged without the tests running than the target being broken on cross' side altogether. |
|
bors r+ |
230: Update emscripten r=reitermarkus a=CryZe rustc switched to emscripten with LLVM 6. emscripten versions with LLVM 4 are not supported anymore. This upgrades emscripten to the same version as rustc is using in its CI. Co-authored-by: Christopher Serr <[email protected]>
Timed out |
1 similar comment
Timed out |
|
bors retry |
230: Update emscripten r=reitermarkus a=CryZe rustc switched to emscripten with LLVM 6. emscripten versions with LLVM 4 are not supported anymore. This upgrades emscripten to the same version as rustc is using in its CI. Co-authored-by: Christopher Serr <[email protected]>
Build succeeded |
rustc switched to emscripten with LLVM 6. emscripten versions with LLVM 4 are not supported anymore. This upgrades emscripten to the same version as rustc is using in its CI.