-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add architecture alias for x86-64: x64 #58
Comments
Do you want the default architecture to follow the host/runner architecture?
Which value is actually passed to the action? You can see that in the log, here's an example: |
Yes, I think that's a better default than any hardcoded value (with a caveat that But of course it's only a suggestion.
It was empty in all 3 cases, but that could be an issue with However, right after I gave up and filled this PR, I found a way to use it:
Note that this evaluates to From the docs for variables in GitHub Actions:
|
Hmm, I'm not sure if I think that's a good API. It would be a breaking change as well, although unlikely someone would be affected. If someone would run this action on a AArch64 self hosted runner (I don't even know if the action works on that).
|
Fair enough!
I thought it did, but now I'm consistently getting this weird error on
I think this issue can be closed, unless you want to keep it open as a reminder to add |
Yeah, that error looks weird. |
architecture
should default to $RUNNER_ARCH
Thanks! |
Release 0.18.0 Added - Add support for custom image URLs ([cross-platform-actions#13](cross-platform-actions#13)) - Add architecture alias for x86-64: x64 ([cross-platform-actions#58](cross-platform-actions#58))
When using act or self-hosted runners, the host could be
aarch64
, at which point the cost of the additional virtualization to the defaultx86_64
architecture is not worth it for someone trying to test if a project builds on a given OS, without caring about the specific architecture.Also, I've tried a few options to set it explicitly to
$RUNNER_ARCH
, but for some reason none of them work, even though I can echo the variable just fine:Any ideas?
The text was updated successfully, but these errors were encountered: