Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: wc 2.0 fix not applied to c++ api (fix #467) #468

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

leejw51crypto
Copy link
Collaborator

apply to c++

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0572f72) 19.03% compared to head (e68cd4a) 19.01%.

Files Patch % Lines
extra-cpp-bindings/src/walletconnect2.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   19.03%   19.01%   -0.02%     
==========================================
  Files          24       24              
  Lines        3877     3881       +4     
==========================================
  Hits          738      738              
- Misses       3139     3143       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leejw51crypto leejw51crypto added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit c4bdafa Dec 6, 2023
22 checks passed
@leejw51crypto leejw51crypto deleted the feature/467 branch April 23, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants