add a job matrix, fix v4 mono #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
job matrix doesnt seem greiat due to testing requirements - potentially could do test duplication across 3 & 4
RGonzalezTech
previously approved these changes
Jun 25, 2023
Closed
i think we're supposed to keep the actual version 4 as the most up-to-date minor version of 4. so e.g. 4.1.3 if that's most recent should also get the tag of 4, and when 4.2 releases we'd also want that to get the 4 tag. i can't remember how to do that tho x.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #29
the test matrix change is just: moving everything to its own job - a normal GH Action matrix doesnt work well due to a matrix running every parameter combination.
the mono fix is due to the docker image not having the .net 6 sdk
@RGonzalezTech i'd recommend immediately patching the 4.0 release so that mono will correctly work. the mono errors were being covered up by the way the single job tests were being run.