Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage GUT XML Output #24

Merged
merged 14 commits into from
Sep 18, 2022
Merged

Leverage GUT XML Output #24

merged 14 commits into from
Sep 18, 2022

Conversation

RGonzalezTech
Copy link
Collaborator

@RGonzalezTech RGonzalezTech commented Sep 15, 2022

Summary

The new GUT versions do not output the results the same way and are causing false negative results. Using the XML output to determine $TESTS and $FAILED. See Original Issue #22

Details

  • Upgraded GUT to 7.4.1
  • Add XML parameter to $RUN_OPTIONS
  • Read the XML file and set values from for tests= and failures=

reviews #22

@RGonzalezTech RGonzalezTech changed the title Leverage GUT XML Output in check_by_tests Leverage GUT XML Output Sep 18, 2022
@RGonzalezTech
Copy link
Collaborator Author

RGonzalezTech commented Sep 18, 2022

Included some parsing for the check_by_asserts function as well. The output XML filename can be defined as a new action input in case it needs to be used with direct-scene.

Concern

See merged PR for more details. Not sure how the -gjunit_xml_file= arg will interact with the -gconfig= input on:

godot-tester/entrypoint.sh

Lines 109 to 113 in a89f81e

if [ "$DIRECT_SCENE" != "false" ]; then
RUN_OPTIONS="${DIRECT_SCENE}"
elif [ "$CONFIG_FILE" != "res://.gutconfig.json" ]; then
RUN_OPTIONS="${RUN_OPTIONS} -gconfig=${CONFIG_FILE}"
fi

@croconut croconut merged commit ccaa85b into croconut:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants