-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Generic Oauth Support #132
base: main
Are you sure you want to change the base?
Conversation
brought over the pr [2211](janeczku/calibre-web#2211) from the parent project to add generic oauth implementation
Hey @MattyIceee, thanks for this! I've read about this whole debacle before on the CW GitHub. Could you please do your best to summarise the situation for me? As far as I can tell the original PR for this was very popular with users and the current head maintainer of CW refused to merge it based on personal biases (or did he have a point in the end?) My questions would be:
Additionally regarding |
Also this pr's diff is a little misleading, and I could've been better with my commit history (apologies, I'm just an overworked software engineer looking to host my books with his sso setup🥲). Because of how this project works (via overlaying its changes onto the original project) I first had to pull the most current versions of the affected files. Then I re-applied the changes I saw in 2211 to them. I haven't done a bunch of research into how this was implemented and quite frankly I don't have the time or desire to. If the libraries used provide us with the functionality they appear to this should resolve a good chunk of custom oidc setups in an "opt in" way. Is it the cleanest change? idk. Is it the safest library,?idk. Are either of those things true for a majority of the oidc implementations we're all already hosting? probably not. As always be sure to have multiple layers of security and hardening setup in your deployments even if using sso. build.sh issue appears to be the docker build unable to find one of the internal directories its creating. I'll review this later but it's probably breaking either do to platform issues (I'm building on windows, I'll try on my Mac later to see if that fixes it) or something env specific, that I'd expect more people to be running into. Thanks again for the project, its pretty neat! |
I got the image up and building but I'm bumping into an unrelated error (as in it happens even when I back out my changes). |
Build an image not with the current repo files as those are very much in active development for the next version, but using the files from the latest release (you can download an archive of them from the repo's Releases page) |
Fixes #90
I just brought over the pr 2211 from the parent project to add generic oauth implementation. I am having trouble testing this as there seems to be an issue with the build.sh. Some help validating would be appreciated.