[data-catalog] create cuttle "readOnlyConnect" method #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonlin1
suggested changes
Mar 18, 2021
| def readOnlyConnect(dbConfig: DatabaseConfig)(implicit logger: Logger): XA = { | ||
| // FIXME we shouldn't use allocated as it's unsafe instead we have to flatMap on the Resource[HikariTransactor] | ||
| val (transactor, _) = newHikariTransactor(dbConfig).allocated.unsafeRunSync | ||
| logger.debug("Allocated new read-only Hikari transactor") |
There was a problem hiding this comment.
could we change this to logger.info instead?
In the read only connection, the db lock is bypassed and the transactor is returned as is. JIRA: DPT-2819
manudizandrei
force-pushed
the
readOnlyConnect
branch
from
1ef4ec3 to
392f861
Compare
antonlin1
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the read only connection, the db lock is bypassed and the transactor is
returned as is.
JIRA: DPT-2819