Post event stream #363
Merged
Post event stream #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to reproduce front end performance issues
as it appears to be much performant with many items looks like w/o much changes, but in case: https://react-select.com/upgrade-guide
- avoid reloading jobs_definition too often - update screen only if paused jobs changed (fixes the popup disappearing while opening it) - force refresh on job action (prevents inconsistent ui / backend states)
as v2 requires much more changes :/ should be better though
at some point it overflows
Also, include Tests in writeClasspath for loop support
to replace eventsource (GET) with poller (POST)
Merged
|
Note that this is based on #362 |
dufrannea
suggested changes
Feb 18, 2019
timeseries/src/main/scala/com/criteo/cuttle/timeseries/TimeSeriesApp.scala
Outdated
Show resolved
Hide resolved
timeseries/src/main/scala/com/criteo/cuttle/timeseries/TimeSeriesApp.scala
Outdated
Show resolved
Hide resolved
vguerci
commented
Feb 18, 2019
timeseries/src/main/scala/com/criteo/cuttle/timeseries/TimeSeriesApp.scala
Outdated
Show resolved
Hide resolved
timeseries/src/main/scala/com/criteo/cuttle/timeseries/TimeSeriesApp.scala
Outdated
Show resolved
Hide resolved
dufrannea
approved these changes
Feb 18, 2019
in order not to break external dependencies on calendar/focus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cuttle use EventSource, with unfortunately does not support POST / body. Because of that, projects with many jobs selected are breaking on these endpoints, reaching Blaze GET url limit.
This PR integrates a PostEventSource that mimics EventSource through POST polling. It is used to replace EventSource in all cases that can fails because of this GET limit.