Configurable logs & timeseries state retention #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dufrannea
approved these changes
Feb 1, 2019
timeseries/src/main/scala/com/criteo/cuttle/timeseries/TimeSeriesScheduler.scala
Show resolved
Hide resolved
dufrannea
suggested changes
Feb 1, 2019
guillaumebort
force-pushed
the
retention
branch
from
85c866b to
a8b3117
Compare
Refactoring how the TimeSeriesScheduler is instantiated (it was a typeclass on Scheduling before but now we don't need to retrieve the instance implicitely). Also cleaning the code duplication between CuttleProject.start & CuttleProject.build
guillaumebort
force-pushed
the
retention
branch
from
a8b3117 to
1070cd1
Compare
dufrannea
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring how the TimeSeriesScheduler is instantiated (it was
a typeclass on Scheduling before but now we don't need to retrieve
the instance implicitely).
Also cleaning the code duplication between CuttleProject.start &
CuttleProject.build