make user's logger used everywhere #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we had a global implicit logger that sometimes was used instead of user specified one, now it's deleted and user logger persisted everywhere simple implicit logger was moved to examples package
dufrannea
suggested changes
Jan 28, 2019
| override def warning(message: => String): Unit = logMe(message, "WARNING") | ||
| override def error(message: => String): Unit = logMe(message, "ERROR") | ||
| } | ||
| implicit val JsonMeta: Meta[Json] = Meta[String].imap(x => parse(x).fold(e => throw e, identity _))( |
There was a problem hiding this comment.
either adapt name to something more self-explanatory, or add a simple comment above. (You can also do both :) )
dufrannea
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had a global implicit logger that sometimes was used instead of
user specified one, now it's deleted and user's logger persisted
everywhere
simple implicit logger was moved to examples package