Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove excessive debug logs #348

Merged
merged 2 commits into from
Jan 23, 2019
Merged

remove excessive debug logs #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8068f
remove doobie debug logs
Jan 23, 2019
557a69c
Merge branch 'master' into eryshev/remove_logging
Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
val devMode = settingKey[Boolean]("Some build optimization are applied in devMode.")
val writeClasspath = taskKey[File]("Write the project classpath to a file.")

val VERSION = "0.5.2"
val VERSION = "0.5.3"

lazy val catsCore = "1.5.0"
lazy val circe = "0.10.1"
Expand Down
2 changes: 0 additions & 2 deletions core/src/main/scala/com/criteo/cuttle/Database.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import io.circe.parser._
import cats.data.NonEmptyList
import cats.implicits._
import cats.effect.{IO, Resource}
import doobie.util.log

import com.criteo.cuttle.ExecutionStatus._
import com.criteo.cuttle.events.{Event, JobSuccessForced}
Expand Down Expand Up @@ -66,7 +65,6 @@ object DatabaseConfig {
}

private[cuttle] object Database {
implicit val logHandler: log.LogHandler = DoobieLogsHandler(logger).handler

implicit val ExecutionStatusMeta: Meta[ExecutionStatus] =
Meta[Boolean].imap(x => if (x) ExecutionSuccessful else ExecutionFailed: ExecutionStatus) {
Expand Down
4 changes: 1 addition & 3 deletions core/src/main/scala/com/criteo/cuttle/Executor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,10 +779,8 @@ class Executor[S <: Scheduling] private[cuttle] (val platforms: Seq[ExecutionPla
val nextExecutionId = utils.randomUUID

val streams = new ExecutionStreams {
def writeln(str: CharSequence) = {
def writeln(str: CharSequence) =
ExecutionStreams.writeln(nextExecutionId, str)
logger.debug(s"[$nextExecutionId] $str")
}
}

// wrap the execution context so that we can register the name of the thread of each
Expand Down