Makes JobState parsing more lenient #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to #299, JobState.Done parsing was not backwards compatible (field projectVersion introduced in case class). The choice has been made here to assign a default version instead of making it optional, in order to minimize bugfix impact on the rest of the codebase.
Masuzu
approved these changes
Nov 9, 2018
bubblesly
pushed a commit
to bubblesly/cuttle
that referenced
this pull request
Nov 20, 2018
Due to criteo#299, JobState.Done parsing was not backwards compatible (field projectVersion introduced in case class). The choice has been made here to assign a default version instead of making it optional, in order to minimize bugfix impact on the rest of the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to #299, JobState.Done
parsing was not backwards compatible (field projectVersion introduced
in case class). The choice has been made here to assign a default
version instead of making it optional, in order to minimize bugfix
impact on the rest of the codebase.