Performance issue with large number of execution #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guillaumebort
commented
Sep 25, 2018
guillaumebort
commented
- Fix a complexity issue is the execution submission loop
- Fix an issue with IO & STM in ExecutionStreams
added 2 commits
September 25, 2018 15:29
Spotted the O(n2)
Masuzu
approved these changes
Sep 25, 2018
Because we build a precomputed index of already running executions by (job, ctx) it won't handle the case where the submitted list contains a duplicate.
vguerci
approved these changes
Sep 26, 2018
Merged
dufrannea
pushed a commit
that referenced
this pull request
Sep 27, 2018
* Fix submission of large number of executions * Fix IO in STM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.