Adds a way of getting ExecutionStream from threadName #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dufrannea
requested review from
Masuzu and
guillaumebort
and removed request for
Masuzu
Masuzu
reviewed
Oct 3, 2018
| Executor.threadNamesToStreams.remove(tName) | ||
| } | ||
| } | ||
| })(Implicits.sideEffectThreadPool) |
There was a problem hiding this comment.
Wouldn't it be worth to remove the other implicit sideEffectThreadPool defined earlier
to make sure that it is the new sideEffectExecutionContext that you redefine (at l.873) which is used everywhere?There was a problem hiding this comment.
Sadly it is used in a few other places, I would like to change this in another PR if that is okay with you
Masuzu
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for example to redirect log4j/slff4j calls to the right executionStream, using a dedicated appender.